Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: services/preferences/public/cpp/tracked/mock_validation_delegate.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/preferences/public/cpp/tracked/mock_validation_delegate.h" 5 #include "services/preferences/public/cpp/tracked/mock_validation_delegate.h"
6 6
7 MockValidationDelegateRecord::MockValidationDelegateRecord() = default; 7 MockValidationDelegateRecord::MockValidationDelegateRecord() = default;
8 8
9 MockValidationDelegateRecord::~MockValidationDelegateRecord() = default; 9 MockValidationDelegateRecord::~MockValidationDelegateRecord() = default;
10 10
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 } 53 }
54 54
55 MockValidationDelegate::MockValidationDelegate( 55 MockValidationDelegate::MockValidationDelegate(
56 scoped_refptr<MockValidationDelegateRecord> record) 56 scoped_refptr<MockValidationDelegateRecord> record)
57 : record_(std::move(record)) {} 57 : record_(std::move(record)) {}
58 58
59 MockValidationDelegate::~MockValidationDelegate() = default; 59 MockValidationDelegate::~MockValidationDelegate() = default;
60 60
61 void MockValidationDelegate::OnAtomicPreferenceValidation( 61 void MockValidationDelegate::OnAtomicPreferenceValidation(
62 const std::string& pref_path, 62 const std::string& pref_path,
63 std::unique_ptr<base::Value> value, 63 const base::Optional<base::Value>& value,
64 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state, 64 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state,
65 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState 65 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState
66 external_validation_value_state, 66 external_validation_value_state,
67 bool is_personal) { 67 bool is_personal) {
68 record_->RecordValidation( 68 record_->RecordValidation(
69 pref_path, value_state, external_validation_value_state, is_personal, 69 pref_path, value_state, external_validation_value_state, is_personal,
70 prefs::mojom::TrackedPreferenceMetadata::PrefTrackingStrategy::ATOMIC); 70 prefs::mojom::TrackedPreferenceMetadata::PrefTrackingStrategy::ATOMIC);
71 } 71 }
72 72
73 void MockValidationDelegate::OnSplitPreferenceValidation( 73 void MockValidationDelegate::OnSplitPreferenceValidation(
74 const std::string& pref_path, 74 const std::string& pref_path,
75 const std::vector<std::string>& invalid_keys, 75 const std::vector<std::string>& invalid_keys,
76 const std::vector<std::string>& external_validation_invalid_keys, 76 const std::vector<std::string>& external_validation_invalid_keys,
77 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state, 77 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state,
78 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState 78 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState
79 external_validation_value_state, 79 external_validation_value_state,
80 bool is_personal) { 80 bool is_personal) {
81 record_->RecordValidation( 81 record_->RecordValidation(
82 pref_path, value_state, external_validation_value_state, is_personal, 82 pref_path, value_state, external_validation_value_state, is_personal,
83 prefs::mojom::TrackedPreferenceMetadata::PrefTrackingStrategy::SPLIT); 83 prefs::mojom::TrackedPreferenceMetadata::PrefTrackingStrategy::SPLIT);
84 } 84 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698