chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h - Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/importer/external_process_importer_client.cc ('k') | chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

diff --git a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

index 4bad0b13d58febb4697d58a878d231489ea662c9..4201241cd610ed89256c50dcc1b0d94ce7a3446b 100644

--- a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

+++ b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

@@ -65,7 +65,7 @@ class SafeMediaMetadataParser

// Runs on the IO thread.

void ParseMediaMetadataDone(

bool parse_success,

- std::unique_ptr<base::DictionaryValue> metadata_dictionary,

+ const base::DictionaryValue& metadata_dictionary,

const std::vector<AttachedImage>& attached_images);

// Sequence of functions that bounces from the IO thread to the UI thread to