Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: services/preferences/tracked/tracked_atomic_preference.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/preferences/public/cpp/tracked/mock_validation_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/preferences/tracked/tracked_atomic_preference.cc
diff --git a/services/preferences/tracked/tracked_atomic_preference.cc b/services/preferences/tracked/tracked_atomic_preference.cc
index 8df3a3609fa096f6651669c88a17f668111c8dd0..48e05ac702bb0c93c76862be89e8d1ca424c9555 100644
--- a/services/preferences/tracked/tracked_atomic_preference.cc
+++ b/services/preferences/tracked/tracked_atomic_preference.cc
@@ -56,8 +56,8 @@ bool TrackedAtomicPreference::EnforceAndReport(
if (delegate_) {
delegate_->OnAtomicPreferenceValidation(
- pref_path_, value ? value->CreateDeepCopy() : nullptr, value_state,
- external_validation_value_state, helper_.IsPersonal());
+ pref_path_, value ? base::Optional<base::Value>(*value) : base::nullopt,
+ value_state, external_validation_value_state, helper_.IsPersonal());
}
TrackedPreferenceHelper::ResetAction reset_action =
helper_.GetAction(value_state);
« no previous file with comments | « services/preferences/public/cpp/tracked/mock_validation_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698