Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: extensions/browser/sandboxed_unpacker.h

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/video_capture_impl_unittest.cc ('k') | extensions/browser/sandboxed_unpacker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/sandboxed_unpacker.h
diff --git a/extensions/browser/sandboxed_unpacker.h b/extensions/browser/sandboxed_unpacker.h
index 5b081df194529f223418b11ef554625d78d37477..165a380a580f6b02073084c4e883fe9d40211ac4 100644
--- a/extensions/browser/sandboxed_unpacker.h
+++ b/extensions/browser/sandboxed_unpacker.h
@@ -206,7 +206,7 @@ class SandboxedUnpacker : public base::RefCountedThreadSafe<SandboxedUnpacker> {
// Unpacks the extension in directory and returns the manifest.
void Unpack(const base::FilePath& directory);
void UnpackDone(const base::string16& error,
- std::unique_ptr<base::DictionaryValue> manifest);
+ const base::Optional<base::DictionaryValue>& manifest);
void UnpackExtensionSucceeded(
std::unique_ptr<base::DictionaryValue> manifest);
void UnpackExtensionFailed(const base::string16& error);
« no previous file with comments | « content/renderer/media/video_capture_impl_unittest.cc ('k') | extensions/browser/sandboxed_unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698