chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc - Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h ('k') | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

diff --git a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

index 675f30e51054db20556a5d5b7d397ce49f16eae9..e6860a7837325da11cf475c91fcb41c8965a5cfe 100644

--- a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

+++ b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

@@ -105,7 +105,7 @@ void SafeMediaMetadataParser::ParseMediaMetadataFailed() {

void SafeMediaMetadataParser::ParseMediaMetadataDone(

bool parse_success,

- std::unique_ptr<base::DictionaryValue> metadata_dictionary,

+ const base::DictionaryValue& metadata_dictionary,

const std::vector<AttachedImage>& attached_images) {

DCHECK_CURRENTLY_ON(content::BrowserThread::IO);

@@ -119,7 +119,8 @@ void SafeMediaMetadataParser::ParseMediaMetadataDone(

content::BrowserThread::PostTask(

content::BrowserThread::UI, FROM_HERE,

- base::Bind(callback_, parse_success, base::Passed(&metadata_dictionary),

+ base::Bind(callback_, parse_success,

+ base::Passed(metadata_dictionary.CreateDeepCopy()),

base::Passed(&attached_images_copy)));

}