chrome/utility/profile_import_handler.h - Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/profile_import_handler.h

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/utility/profile_import_handler.h

diff --git a/chrome/utility/profile_import_handler.h b/chrome/utility/profile_import_handler.h

index cdc85cbadaf970e9edc98ab39233daf49a79d3c5..7b687ac9df0f54d089ce56f66cc370af4a02ab9b 100644

--- a/chrome/utility/profile_import_handler.h

+++ b/chrome/utility/profile_import_handler.h

@@ -40,7 +40,7 @@ class ProfileImportHandler : public chrome::mojom::ProfileImport {

// chrome::mojom::ProfileImport:

void StartImport(const importer::SourceProfile& source_profile,

uint16_t items,

- std::unique_ptr<base::DictionaryValue> localized_strings,

+ const base::DictionaryValue& localized_strings,

chrome::mojom::ProfileImportObserverPtr observer) override;

void CancelImport() override;

void ReportImportItemFinished(importer::ImportItem item) override;