s/same_page/same_document for DidCommitProvisionalLoad method.

s/same_page/same_document for DidCommitProvisionalLoad method.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
Review-Url: https://codereview.chromium.org/2775963002
Cr-Commit-Position: refs/heads/master@{#460143}
Committed: https://chromium.googlesource.com/chromium/src/+/5ae751e8e94501c884e5ac2335cc358f37310129

[Eugene But (OOO till 7-30), 2017-03-24 21:58:44]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 21:59:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 22:14:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 22:14:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eugene But (OOO till 7-30), 2017-03-24 22:26:18]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 22:26:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 22:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 22:34:01]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Eugene But (OOO till 7-30), 2017-03-25 00:36:29]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 00:37:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 00:48:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 00:48:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eugene But (OOO till 7-30), 2017-03-25 00:53:46]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 00:54:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 01:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 01:46:10]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-03-27 16:18:00]

eugenebut@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2017-03-27 20:00:21]

LGTM with a nit.

https://codereview.chromium.org/2775963002/diff/40001/chrome/renderer/page_lo...
File chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc (right):

https://codereview.chromium.org/2775963002/diff/40001/chrome/renderer/page_lo...
chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc:61: //
resource. DidStartProvisionalLoad doesn't get invoked for same page
s/same page/same document/

[Eugene But (OOO till 7-30), 2017-03-27 20:41:39]

eugenebut@chromium.org changed reviewers:
+ jochen@chromium.org, michaelbai@chromium.org

[Eugene But (OOO till 7-30), 2017-03-27 20:41:40]

Thanks! Adding more reviewers:

jochen@ for chrome and components
michaelbai@ for android_webview

https://codereview.chromium.org/2775963002/diff/40001/chrome/renderer/page_lo...
File chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc (right):

https://codereview.chromium.org/2775963002/diff/40001/chrome/renderer/page_lo...
chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc:61: //
resource. DidStartProvisionalLoad doesn't get invoked for same page
On 2017/03/27 20:00:21, nasko wrote:
> s/same page/same document/

Done.

[jochen (gone - plz use gerrit), 2017-03-28 10:33:58]

lgtm

[michaelbai, 2017-03-28 15:48:15]

android_webview LGTM

[Eugene But (OOO till 7-30), 2017-03-28 16:06:32]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-28 16:06:32]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2775963002/#ps60001
(title: "Addressed review comment")

[commit-bot: I haz the power, 2017-03-28 16:07:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:10:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490717192343860,
"parent_rev": "64bb332d22780352a0d2dbbd802d158aa9664af0", "commit_rev":
"5ae751e8e94501c884e5ac2335cc358f37310129"}

[commit-bot: I haz the power, 2017-03-28 17:11:31]

Description was changed from

==========
s/same_page/same_document for DidCommitProvisionalLoad method.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
==========

to

==========
s/same_page/same_document for DidCommitProvisionalLoad method.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189

Review-Url: https://codereview.chromium.org/2775963002
Cr-Commit-Position: refs/heads/master@{#460143}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ae751e8e94501c884e5ac2335cc...
==========

[commit-bot: I haz the power, 2017-03-28 17:11:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5ae751e8e94501c884e5ac2335cc...