content/renderer/presentation/presentation_dispatcher.h - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_dispatcher.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/presentation/presentation_dispatcher.h

diff --git a/content/renderer/presentation/presentation_dispatcher.h b/content/renderer/presentation/presentation_dispatcher.h

index 96fa3f8f6557f8f024f9bc03cc7ab9d045f518c1..39d53c0e0285f070dda1ea0b20ca6c1a83e794a5 100644

--- a/content/renderer/presentation/presentation_dispatcher.h

+++ b/content/renderer/presentation/presentation_dispatcher.h

@@ -151,9 +151,8 @@ class CONTENT_EXPORT PresentationDispatcher

const blink::WebVector<blink::WebURL>& presentationUrls) override;

// RenderFrameObserver implementation.

- void DidCommitProvisionalLoad(

- bool is_new_navigation,

- bool is_same_page_navigation) override;

+ void DidCommitProvisionalLoad(bool is_new_navigation,

+ bool is_same_document_navigation) override;

void OnDestruct() override;

void WidgetWillClose() override;