components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/subresource_filter_agent.cc ('k') | content/public/renderer/render_frame_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

index bbda559ba507633c18e379be8be5074fa1bd1a85..6b34b7195b198238f3fe1940c50a919c7849475d 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

@@ -124,7 +124,7 @@ class SubresourceFilterAgentTest : public ::testing::Test {

void StartLoadWithoutSettingActivationLevel() {

agent_as_rfo()->DidStartProvisionalLoad(nullptr);

agent_as_rfo()->DidCommitProvisionalLoad(

- true /* is_new_navigation */, false /* is_same_page_navigation */);

+ true /* is_new_navigation */, false /* is_same_document_navigation */);

}

void PerformSamePageNavigationWithoutSettingActivationLevel() {

@@ -141,7 +141,7 @@ class SubresourceFilterAgentTest : public ::testing::Test {

SubresourceFilterMsg_ActivateForNextCommittedLoad(

0, activation_level, measure_performance)));

agent_as_rfo()->DidCommitProvisionalLoad(

- true /* is_new_navigation */, false /* is_same_page_navigation */);

+ true /* is_new_navigation */, false /* is_same_document_navigation */);

}

void FinishLoad() { agent_as_rfo()->DidFinishLoad(); }

@@ -420,8 +420,8 @@ TEST_F(SubresourceFilterAgentTest,

0, ActivationLevel::ENABLED, true)));

agent_as_rfo()->DidFailProvisionalLoad(blink::WebURLError());

agent_as_rfo()->DidStartProvisionalLoad(nullptr);

- agent_as_rfo()->DidCommitProvisionalLoad(true /* is_new_navigation */,

- false /* is_same_page_navigation */);

+ agent_as_rfo()->DidCommitProvisionalLoad(

+ true /* is_new_navigation */, false /* is_same_document_navigation */);

FinishLoad();

}