Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 17 matching lines...) Expand all
28 class MetricsRenderFrameObserver : public content::RenderFrameObserver { 28 class MetricsRenderFrameObserver : public content::RenderFrameObserver {
29 public: 29 public:
30 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); 30 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame);
31 ~MetricsRenderFrameObserver() override; 31 ~MetricsRenderFrameObserver() override;
32 32
33 // RenderFrameObserver implementation 33 // RenderFrameObserver implementation
34 void DidChangePerformanceTiming() override; 34 void DidChangePerformanceTiming() override;
35 void DidObserveLoadingBehavior( 35 void DidObserveLoadingBehavior(
36 blink::WebLoadingBehaviorFlag behavior) override; 36 blink::WebLoadingBehaviorFlag behavior) override;
37 void DidCommitProvisionalLoad(bool is_new_navigation, 37 void DidCommitProvisionalLoad(bool is_new_navigation,
38 bool is_same_page_navigation) override; 38 bool is_same_document_navigation) override;
39 void OnDestruct() override; 39 void OnDestruct() override;
40 40
41 // Invoked when a frame is going away. This is our last chance to send IPCs 41 // Invoked when a frame is going away. This is our last chance to send IPCs
42 // before being destroyed. 42 // before being destroyed.
43 void FrameDetached() override; 43 void FrameDetached() override;
44 44
45 private: 45 private:
46 // Will be null when we're not actively sending metrics. 46 // Will be null when we're not actively sending metrics.
47 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_; 47 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
48 48
49 void SendMetrics(); 49 void SendMetrics();
50 virtual bool ShouldSendMetrics() const; 50 virtual bool ShouldSendMetrics() const;
51 virtual PageLoadTiming GetTiming() const; 51 virtual PageLoadTiming GetTiming() const;
52 virtual std::unique_ptr<base::Timer> CreateTimer() const; 52 virtual std::unique_ptr<base::Timer> CreateTimer() const;
53 virtual bool HasNoRenderFrame() const; 53 virtual bool HasNoRenderFrame() const;
54 virtual bool IsMainFrame() const; 54 virtual bool IsMainFrame() const;
55 55
56 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); 56 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
57 }; 57 };
58 58
59 } // namespace page_load_metrics 59 } // namespace page_load_metrics
60 60
61 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 61 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/net/net_error_helper.cc ('k') | chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698