content/renderer/manifest/manifest_manager.cc - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/manifest/manifest_manager.cc

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/manifest/manifest_manager.cc

diff --git a/content/renderer/manifest/manifest_manager.cc b/content/renderer/manifest/manifest_manager.cc

index b6d3b819087515bd813fc447ee166ba8c45e56e8..e7ccbe1c312c5a0a12a041855ca7f5ee17c96087 100644

--- a/content/renderer/manifest/manifest_manager.cc

+++ b/content/renderer/manifest/manifest_manager.cc

@@ -107,8 +107,8 @@ void ManifestManager::DidChangeManifest() {

void ManifestManager::DidCommitProvisionalLoad(

bool is_new_navigation,

- bool is_same_page_navigation) {

- if (is_same_page_navigation)

+ bool is_same_document_navigation) {

+ if (is_same_document_navigation)

return;

may_have_manifest_ = false;