Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: content/public/renderer/render_frame_observer.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
6 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_ 6 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // Called when associated widget is about to close. 55 // Called when associated widget is about to close.
56 virtual void WidgetWillClose() {} 56 virtual void WidgetWillClose() {}
57 57
58 // These match the Blink API notifications 58 // These match the Blink API notifications
59 virtual void DidCreateNewDocument() {} 59 virtual void DidCreateNewDocument() {}
60 virtual void DidCreateDocumentElement() {} 60 virtual void DidCreateDocumentElement() {}
61 // Called when a provisional load is about to commit in a frame. This is 61 // Called when a provisional load is about to commit in a frame. This is
62 // dispatched just before the Javascript unload event. 62 // dispatched just before the Javascript unload event.
63 virtual void WillCommitProvisionalLoad() {} 63 virtual void WillCommitProvisionalLoad() {}
64 virtual void DidCommitProvisionalLoad(bool is_new_navigation, 64 virtual void DidCommitProvisionalLoad(bool is_new_navigation,
65 bool is_same_page_navigation) {} 65 bool is_same_document_navigation) {}
66 virtual void DidStartProvisionalLoad(blink::WebDataSource* data_source) {} 66 virtual void DidStartProvisionalLoad(blink::WebDataSource* data_source) {}
67 virtual void DidFailProvisionalLoad(const blink::WebURLError& error) {} 67 virtual void DidFailProvisionalLoad(const blink::WebURLError& error) {}
68 virtual void DidFinishLoad() {} 68 virtual void DidFinishLoad() {}
69 virtual void DidFinishDocumentLoad() {} 69 virtual void DidFinishDocumentLoad() {}
70 virtual void DidCreateScriptContext(v8::Local<v8::Context> context, 70 virtual void DidCreateScriptContext(v8::Local<v8::Context> context,
71 int world_id) {} 71 int world_id) {}
72 virtual void WillReleaseScriptContext(v8::Local<v8::Context> context, 72 virtual void WillReleaseScriptContext(v8::Local<v8::Context> context,
73 int world_id) {} 73 int world_id) {}
74 virtual void DidClearWindowObject() {} 74 virtual void DidClearWindowObject() {}
75 virtual void DidChangeManifest() {} 75 virtual void DidChangeManifest() {}
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 RenderFrame* render_frame_; 147 RenderFrame* render_frame_;
148 // The routing ID of the associated RenderFrame. 148 // The routing ID of the associated RenderFrame.
149 int routing_id_; 149 int routing_id_;
150 150
151 DISALLOW_COPY_AND_ASSIGN(RenderFrameObserver); 151 DISALLOW_COPY_AND_ASSIGN(RenderFrameObserver);
152 }; 152 };
153 153
154 } // namespace content 154 } // namespace content
155 155
156 #endif // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_ 156 #endif // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698