Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
index 9465960608042e8f7c87b45e99c3fc4fd1cf7008..db2cbfaaf74c8dfed784c56d2d6a161db17dc82d 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
@@ -55,13 +55,13 @@ void MetricsRenderFrameObserver::FrameDetached() {
void MetricsRenderFrameObserver::DidCommitProvisionalLoad(
bool is_new_navigation,
- bool is_same_page_navigation) {
- // Same-page navigations (e.g. an in-document navigation from a fragment
- // link) aren't full page loads, since they don't go to network to load the
- // main HTML resource. DidStartProvisionalLoad doesn't get invoked for same
- // page navigations, so we may still have an active
- // page_timing_metrics_sender_ at this point.
- if (is_same_page_navigation)
+ bool is_same_document_navigation) {
+ // Same-document navigations (e.g. a navigation from a fragment link) aren't
+ // full page loads, since they don't go to network to load the main HTML
+ // resource. DidStartProvisionalLoad doesn't get invoked for same document
+ // navigations, so we may still have an active page_timing_metrics_sender_ at
+ // this point.
+ if (is_same_document_navigation)
return;
// Make sure to release the sender for a previous navigation, if we have one.

Powered by Google App Engine
This is Rietveld 408576698