components/subresource_filter/content/renderer/subresource_filter_agent.cc - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent.cc

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/subresource_filter_agent.h ('k') | components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent.cc

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent.cc b/components/subresource_filter/content/renderer/subresource_filter_agent.cc

index b23a8b2a29a71cf66d1569deb2ebd5aab10b0d68..13b4c7b14bf038f84a880393246a5e0223584d36 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent.cc

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.cc

@@ -143,8 +143,8 @@ void SubresourceFilterAgent::OnDestruct() {

void SubresourceFilterAgent::DidCommitProvisionalLoad(

bool is_new_navigation,

- bool is_same_page_navigation) {

- if (is_same_page_navigation)

+ bool is_same_document_navigation) {

+ if (is_same_document_navigation)

return;

filter_for_last_committed_load_.reset();