Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Side by Side Diff: chrome/renderer/chrome_render_frame_observer.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_
6 #define CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_ 6 #define CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/timer/timer.h" 9 #include "base/timer/timer.h"
10 #include "chrome/common/image_context_menu_renderer.mojom.h" 10 #include "chrome/common/image_context_menu_renderer.mojom.h"
(...skipping 25 matching lines...) Expand all
36 ~ChromeRenderFrameObserver() override; 36 ~ChromeRenderFrameObserver() override;
37 37
38 private: 38 private:
39 enum TextCaptureType { PRELIMINARY_CAPTURE, FINAL_CAPTURE }; 39 enum TextCaptureType { PRELIMINARY_CAPTURE, FINAL_CAPTURE };
40 40
41 // RenderFrameObserver implementation. 41 // RenderFrameObserver implementation.
42 bool OnMessageReceived(const IPC::Message& message) override; 42 bool OnMessageReceived(const IPC::Message& message) override;
43 void DidStartProvisionalLoad(blink::WebDataSource* data_source) override; 43 void DidStartProvisionalLoad(blink::WebDataSource* data_source) override;
44 void DidFinishLoad() override; 44 void DidFinishLoad() override;
45 void DidCommitProvisionalLoad(bool is_new_navigation, 45 void DidCommitProvisionalLoad(bool is_new_navigation,
46 bool is_same_page_navigation) override; 46 bool is_same_document_navigation) override;
47 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override; 47 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;
48 void OnDestruct() override; 48 void OnDestruct() override;
49 49
50 // chrome::mojom::ImageContextMenuRenderer: 50 // chrome::mojom::ImageContextMenuRenderer:
51 void RequestReloadImageForContextNode() override; 51 void RequestReloadImageForContextNode() override;
52 52
53 // chrome::mojom::ThumbnailCapturer: 53 // chrome::mojom::ThumbnailCapturer:
54 void RequestThumbnailForContextNode( 54 void RequestThumbnailForContextNode(
55 int32_t thumbnail_min_area_pixels, 55 int32_t thumbnail_min_area_pixels,
56 const gfx::Size& thumbnail_max_size_pixels, 56 const gfx::Size& thumbnail_max_size_pixels,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 mojo::BindingSet<chrome::mojom::ImageContextMenuRenderer> 88 mojo::BindingSet<chrome::mojom::ImageContextMenuRenderer>
89 image_context_menu_renderer_bindings_; 89 image_context_menu_renderer_bindings_;
90 90
91 mojo::BindingSet<chrome::mojom::ThumbnailCapturer> 91 mojo::BindingSet<chrome::mojom::ThumbnailCapturer>
92 thumbnail_capturer_bindings_; 92 thumbnail_capturer_bindings_;
93 93
94 DISALLOW_COPY_AND_ASSIGN(ChromeRenderFrameObserver); 94 DISALLOW_COPY_AND_ASSIGN(ChromeRenderFrameObserver);
95 }; 95 };
96 96
97 #endif // CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_ 97 #endif // CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | chrome/renderer/chrome_render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698