Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index a0e275a98b78d2ec95e7177d25233c59cd00bb6b..d80580fc53deb5c8c5efba04fa0208a5c02a51d2 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -182,15 +182,15 @@ bool AutofillAgent::FormDataCompare::operator()(const FormData& lhs,
}
void AutofillAgent::DidCommitProvisionalLoad(bool is_new_navigation,
- bool is_same_page_navigation) {
+ bool is_same_document_navigation) {
blink::WebFrame* frame = render_frame()->GetWebFrame();
// TODO(dvadym): check if we need to check if it is main frame navigation
// http://crbug.com/443155
if (frame->parent())
return; // Not a top-level navigation.
- if (is_same_page_navigation) {
- OnSamePageNavigationCompleted();
+ if (is_same_document_navigation) {
+ OnSameDocumentNavigationCompleted();
} else {
// Navigation to a new page or a page refresh.
form_cache_.Reset();
@@ -578,7 +578,7 @@ void AutofillAgent::ShowNotSecureWarning(
is_popup_possibly_visible_ = true;
}
-void AutofillAgent::OnSamePageNavigationCompleted() {
+void AutofillAgent::OnSameDocumentNavigationCompleted() {
if (last_interacted_form_.isNull()) {
// If no last interacted form is available (i.e., there is no form tag),
// we check if all the elements the user has interacted with are gone,
@@ -780,7 +780,7 @@ void AutofillAgent::didAssociateFormControlsDynamically() {
}
void AutofillAgent::ajaxSucceeded() {
- OnSamePageNavigationCompleted();
+ OnSameDocumentNavigationCompleted();
password_autofill_agent_->AJAXSucceeded();
}
« no previous file with comments | « components/autofill/content/renderer/autofill_agent.h ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698