Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 // autocomplete). 142 // autocomplete).
143 bool show_full_suggestion_list; 143 bool show_full_suggestion_list;
144 144
145 // Specifies that only show a suggestions box if |element| is part of a 145 // Specifies that only show a suggestions box if |element| is part of a
146 // password form, otherwise show no suggestions. 146 // password form, otherwise show no suggestions.
147 bool show_password_suggestions_only; 147 bool show_password_suggestions_only;
148 }; 148 };
149 149
150 // content::RenderFrameObserver: 150 // content::RenderFrameObserver:
151 void DidCommitProvisionalLoad(bool is_new_navigation, 151 void DidCommitProvisionalLoad(bool is_new_navigation,
152 bool is_same_page_navigation) override; 152 bool is_same_document_navigation) override;
153 void DidFinishDocumentLoad() override; 153 void DidFinishDocumentLoad() override;
154 void WillSendSubmitEvent(const blink::WebFormElement& form) override; 154 void WillSendSubmitEvent(const blink::WebFormElement& form) override;
155 void WillSubmitForm(const blink::WebFormElement& form) override; 155 void WillSubmitForm(const blink::WebFormElement& form) override;
156 void DidChangeScrollOffset() override; 156 void DidChangeScrollOffset() override;
157 void FocusedNodeChanged(const blink::WebNode& node) override; 157 void FocusedNodeChanged(const blink::WebNode& node) override;
158 void OnDestruct() override; 158 void OnDestruct() override;
159 159
160 // Fires IPC messages for a given form submission. Will always fire 160 // Fires IPC messages for a given form submission. Will always fire
161 // AutofillHostMsg_WillSubmitForm, and will also fire 161 // AutofillHostMsg_WillSubmitForm, and will also fire
162 // AutofillHostMsg_FormSubmitted if |form_submitted| is true. Respects 162 // AutofillHostMsg_FormSubmitted if |form_submitted| is true. Respects
(...skipping 19 matching lines...) Expand all
182 void textFieldDidEndEditing(const blink::WebInputElement& element) override; 182 void textFieldDidEndEditing(const blink::WebInputElement& element) override;
183 void textFieldDidChange(const blink::WebFormControlElement& element) override; 183 void textFieldDidChange(const blink::WebFormControlElement& element) override;
184 void textFieldDidReceiveKeyDown( 184 void textFieldDidReceiveKeyDown(
185 const blink::WebInputElement& element, 185 const blink::WebInputElement& element,
186 const blink::WebKeyboardEvent& event) override; 186 const blink::WebKeyboardEvent& event) override;
187 void openTextDataListChooser(const blink::WebInputElement& element) override; 187 void openTextDataListChooser(const blink::WebInputElement& element) override;
188 void dataListOptionsChanged(const blink::WebInputElement& element) override; 188 void dataListOptionsChanged(const blink::WebInputElement& element) override;
189 void firstUserGestureObserved() override; 189 void firstUserGestureObserved() override;
190 void ajaxSucceeded() override; 190 void ajaxSucceeded() override;
191 191
192 // Called when a same-page navigation is detected. 192 // Called when a same-document navigation is detected.
193 void OnSamePageNavigationCompleted(); 193 void OnSameDocumentNavigationCompleted();
194 // Helper method which collects unowned elements (i.e., those not inside a 194 // Helper method which collects unowned elements (i.e., those not inside a
195 // form tag) and writes them into |output|. Returns true if the process is 195 // form tag) and writes them into |output|. Returns true if the process is
196 // successful, and all conditions for firing events are true. 196 // successful, and all conditions for firing events are true.
197 bool CollectFormlessElements(FormData* output); 197 bool CollectFormlessElements(FormData* output);
198 FRIEND_TEST_ALL_PREFIXES(FormAutocompleteTest, CollectFormlessElements); 198 FRIEND_TEST_ALL_PREFIXES(FormAutocompleteTest, CollectFormlessElements);
199 199
200 // Called in a posted task by textFieldDidChange() to work-around a WebKit bug 200 // Called in a posted task by textFieldDidChange() to work-around a WebKit bug
201 // http://bugs.webkit.org/show_bug.cgi?id=16976 201 // http://bugs.webkit.org/show_bug.cgi?id=16976
202 void TextFieldDidChangeImpl(const blink::WebFormControlElement& element); 202 void TextFieldDidChangeImpl(const blink::WebFormControlElement& element);
203 203
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 mojom::AutofillDriverPtr autofill_driver_; 304 mojom::AutofillDriverPtr autofill_driver_;
305 305
306 base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_; 306 base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
307 307
308 DISALLOW_COPY_AND_ASSIGN(AutofillAgent); 308 DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
309 }; 309 };
310 310
311 } // namespace autofill 311 } // namespace autofill
312 312
313 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 313 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
OLDNEW
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_delegate.cc ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698