chrome/renderer/chrome_render_frame_observer.h - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_frame_observer.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_render_frame_observer.h

diff --git a/chrome/renderer/chrome_render_frame_observer.h b/chrome/renderer/chrome_render_frame_observer.h

index d4c22b8c6b98fd51545b317850dd814e1c0f7bae..633a63b69f5421b14c167194ea963230063063c6 100644

--- a/chrome/renderer/chrome_render_frame_observer.h

+++ b/chrome/renderer/chrome_render_frame_observer.h

@@ -43,7 +43,7 @@ class ChromeRenderFrameObserver

void DidStartProvisionalLoad(blink::WebDataSource* data_source) override;

void DidFinishLoad() override;

void DidCommitProvisionalLoad(bool is_new_navigation,

- bool is_same_page_navigation) override;

+ bool is_same_document_navigation) override;

void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;

void OnDestruct() override;