chrome/renderer/chrome_render_frame_observer.cc - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_frame_observer.cc

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_render_frame_observer.cc

diff --git a/chrome/renderer/chrome_render_frame_observer.cc b/chrome/renderer/chrome_render_frame_observer.cc

index cb86e0b0b685749e7956040a771bf913d088d67f..6e4407d60a5fa16fb20d05464f90eced6ec5b8c1 100644

--- a/chrome/renderer/chrome_render_frame_observer.cc

+++ b/chrome/renderer/chrome_render_frame_observer.cc

@@ -273,7 +273,7 @@ void ChromeRenderFrameObserver::DidStartProvisionalLoad(

void ChromeRenderFrameObserver::DidCommitProvisionalLoad(

bool is_new_navigation,

- bool is_same_page_navigation) {

+ bool is_same_document_navigation) {

WebLocalFrame* frame = render_frame()->GetWebFrame();

// Don't do anything for subframes.