Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index cb66f89d99bb1527137d14d51024234d12ff65e1..653786ce838107646c0759a44253e8e42f5876fc 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -993,10 +993,10 @@ void PasswordAutofillAgent::OnDynamicFormsSeen() {
}
void PasswordAutofillAgent::AJAXSucceeded() {
- OnSamePageNavigationCompleted();
+ OnSameDocumentNavigationCompleted();
}
-void PasswordAutofillAgent::OnSamePageNavigationCompleted() {
+void PasswordAutofillAgent::OnSameDocumentNavigationCompleted() {
if (!provisionally_saved_form_.IsPasswordValid())
return;
@@ -1154,9 +1154,10 @@ void PasswordAutofillAgent::WillCommitProvisionalLoad() {
}
void PasswordAutofillAgent::DidCommitProvisionalLoad(
- bool is_new_navigation, bool is_same_page_navigation) {
- if (is_same_page_navigation) {
- OnSamePageNavigationCompleted();
+ bool is_new_navigation,
+ bool is_same_document_navigation) {
+ if (is_same_document_navigation) {
+ OnSameDocumentNavigationCompleted();
}
}

Powered by Google App Engine
This is Rietveld 408576698