s/same_page/same_document for DidCommitProvisionalLoad method.

chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
@@ skipping 37 matching lines @@
   if (page_timing_metrics_sender_)
     page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);
 }
 
 void MetricsRenderFrameObserver::FrameDetached() {
   page_timing_metrics_sender_.reset();
 }
 
 void MetricsRenderFrameObserver::DidCommitProvisionalLoad(
     bool is_new_navigation,
-    bool is_same_page_navigation) {
-  // Same-page navigations (e.g. an in-document navigation from a fragment
-  // link) aren't full page loads, since they don't go to network to load the
-  // main HTML resource. DidStartProvisionalLoad doesn't get invoked for same
-  // page navigations, so we may still have an active
-  // page_timing_metrics_sender_ at this point.
-  if (is_same_page_navigation)
+    bool is_same_document_navigation) {
+  // Same-document navigations (e.g. a navigation from a fragment link) aren't
+  // full page loads, since they don't go to network to load the main HTML
+  // resource. DidStartProvisionalLoad doesn't get invoked for same page

[nasko, 2017/03/27 20:00:21]

s/same page/same document/

[Eugene But (OOO till 7-30), 2017/03/27 20:41:40]

Done.

+  // navigations, so we may still have an active page_timing_metrics_sender_ at
+  // this point.
+  if (is_same_document_navigation)
     return;
 
   // Make sure to release the sender for a previous navigation, if we have one.
   page_timing_metrics_sender_.reset();
 
   // We only create a PageTimingMetricsSender if the page meets the criteria for
   // sending and recording metrics. Once page_timing_metrics_sender_ is
   // non-null, we will send metrics for the current page at some later time, as
   // those metrics become available.
   if (ShouldSendMetrics()) {
@@ skipping 100 matching lines @@
 
 void MetricsRenderFrameObserver::OnDestruct() {
   delete this;
 }
 
 bool MetricsRenderFrameObserver::IsMainFrame() const {
   return render_frame()->IsMainFrame();
 }
 
 }  // namespace page_load_metrics