chrome/renderer/page_load_metrics/metrics_render_frame_observer.h - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

index d37b673b9f53f7a0d9f4676cde8330481ef60344..3b9ad1e915cf3a676e7ba8a0557378eea7038a91 100644

--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

@@ -35,7 +35,7 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {

void DidObserveLoadingBehavior(

blink::WebLoadingBehaviorFlag behavior) override;

void DidCommitProvisionalLoad(bool is_new_navigation,

- bool is_same_page_navigation) override;

+ bool is_same_document_navigation) override;

void OnDestruct() override;

// Invoked when a frame is going away. This is our last chance to send IPCs