android_webview/renderer/aw_render_frame_ext.h - Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/aw_render_frame_ext.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)

Patch Set: Addressed review comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/renderer/aw_render_frame_ext.h

diff --git a/android_webview/renderer/aw_render_frame_ext.h b/android_webview/renderer/aw_render_frame_ext.h

index 6551c733ef246a7c4c32b0be6f778c81d06f9fec..672946b445e324caf28a31f6fc172424ea0a3542 100644

--- a/android_webview/renderer/aw_render_frame_ext.h

+++ b/android_webview/renderer/aw_render_frame_ext.h

@@ -32,7 +32,7 @@ class AwRenderFrameExt : public content::RenderFrameObserver {

// RenderFrameObserver:

void DidCommitProvisionalLoad(bool is_new_navigation,

- bool is_same_page_navigation) override;

+ bool is_same_document_navigation) override;

bool OnMessageReceived(const IPC::Message& message) override;

void FocusedNodeChanged(const blink::WebNode& node) override;

« no previous file with comments | « no previous file | android_webview/renderer/aw_render_frame_ext.cc » ('j') | no next file with comments »