Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: content/renderer/manifest/manifest_manager.h

Issue 2775963002: s/same_page/same_document for DidCommitProvisionalLoad method. (Closed)
Patch Set: Addressed review comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_ 5 #ifndef CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_
6 #define CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_ 6 #define CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 29 matching lines...) Expand all
40 ~ManifestManager() override; 40 ~ManifestManager() override;
41 41
42 // Will call the given |callback| with the Manifest associated with the 42 // Will call the given |callback| with the Manifest associated with the
43 // RenderFrame if any. Will pass an empty Manifest in case of error. 43 // RenderFrame if any. Will pass an empty Manifest in case of error.
44 void GetManifest(const GetManifestCallback& callback); 44 void GetManifest(const GetManifestCallback& callback);
45 45
46 // RenderFrameObserver implementation. 46 // RenderFrameObserver implementation.
47 bool OnMessageReceived(const IPC::Message& message) override; 47 bool OnMessageReceived(const IPC::Message& message) override;
48 void DidChangeManifest() override; 48 void DidChangeManifest() override;
49 void DidCommitProvisionalLoad(bool is_new_navigation, 49 void DidCommitProvisionalLoad(bool is_new_navigation,
50 bool is_same_page_navigation) override; 50 bool is_same_document_navigation) override;
51 51
52 private: 52 private:
53 enum ResolveState { 53 enum ResolveState {
54 ResolveStateSuccess, 54 ResolveStateSuccess,
55 ResolveStateFailure 55 ResolveStateFailure
56 }; 56 };
57 57
58 // RenderFrameObserver implementation. 58 // RenderFrameObserver implementation.
59 void OnDestruct() override; 59 void OnDestruct() override;
60 60
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 ManifestDebugInfo manifest_debug_info_; 93 ManifestDebugInfo manifest_debug_info_;
94 94
95 std::list<GetManifestCallback> pending_callbacks_; 95 std::list<GetManifestCallback> pending_callbacks_;
96 96
97 DISALLOW_COPY_AND_ASSIGN(ManifestManager); 97 DISALLOW_COPY_AND_ASSIGN(ManifestManager);
98 }; 98 };
99 99
100 } // namespace content 100 } // namespace content
101 101
102 #endif // CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_ 102 #endif // CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_
OLDNEW
« no previous file with comments | « content/public/renderer/render_frame_observer.h ('k') | content/renderer/manifest/manifest_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698