[ios] Add TODO to record usages of "return std::move(foo)" pattern.

[ios] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

BUG=703565
Review-Url: https://codereview.chromium.org/2762973002
Cr-Commit-Position: refs/heads/master@{#458456}
Committed: https://chromium.googlesource.com/chromium/src/+/99854454417e7c9ad57d2d2d441ef17cc481ba2d

[sdefresne, 2017-03-21 10:14:44]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 10:15:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-21 10:16:03]

sdefresne@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[sdefresne, 2017-03-21 10:16:04]

Please take a look.

[commit-bot: I haz the power, 2017-03-21 10:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 10:31:03]

Dry run: This issue passed the CQ dry run.

[Olivier, 2017-03-21 10:31:45]

lgtm

[sdefresne, 2017-03-21 10:46:50]

Description was changed from

==========
[ios] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

BUG=703565
==========

to

==========
[ios] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

BUG=703565
==========

[sdefresne, 2017-03-21 10:46:50]

sdefresne@chromium.org changed reviewers:
+ eugenebut@chromium.org

[sdefresne, 2017-03-21 10:47:09]

eugenebut: please do OWNERS review of ios/web and send to CQ if LGTY.

[Eugene But (OOO till 7-30), 2017-03-21 15:54:05]

lgtm

[sdefresne, 2017-03-21 17:16:37]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-03-21 17:17:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 17:30:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490116597290920, "parent_rev":
"f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b", "commit_rev":
"99854454417e7c9ad57d2d2d441ef17cc481ba2d"}

[commit-bot: I haz the power, 2017-03-21 17:31:12]

Description was changed from

==========
[ios] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

BUG=703565
==========

to

==========
[ios] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

BUG=703565

Review-Url: https://codereview.chromium.org/2762973002
Cr-Commit-Position: refs/heads/master@{#458456}
Committed:
https://chromium.googlesource.com/chromium/src/+/99854454417e7c9ad57d2d2d441e...
==========

[commit-bot: I haz the power, 2017-03-21 17:31:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99854454417e7c9ad57d2d2d441e...