ios/chrome/browser/signin/account_reconcilor_factory.cc - Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/signin/account_reconcilor_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/signin/account_fetcher_service_factory.cc ('k') | ios/chrome/browser/signin/account_tracker_service_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ios/chrome/browser/signin/account_reconcilor_factory.h"	5 #include "ios/chrome/browser/signin/account_reconcilor_factory.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "base/memory/singleton.h"	9 #include "base/memory/singleton.h"

10 #include "components/keyed_service/ios/browser_state_dependency_manager.h"	10 #include "components/keyed_service/ios/browser_state_dependency_manager.h"

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 web::BrowserState* context) const {	45 web::BrowserState* context) const {

46 ios::ChromeBrowserState* chrome_browser_state =	46 ios::ChromeBrowserState* chrome_browser_state =

47 ios::ChromeBrowserState::FromBrowserState(context);	47 ios::ChromeBrowserState::FromBrowserState(context);

48 std::unique_ptr<AccountReconcilor> reconcilor(new AccountReconcilor(	48 std::unique_ptr<AccountReconcilor> reconcilor(new AccountReconcilor(

49 OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state),	49 OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state),

50 SigninManagerFactory::GetForBrowserState(chrome_browser_state),	50 SigninManagerFactory::GetForBrowserState(chrome_browser_state),

51 SigninClientFactory::GetForBrowserState(chrome_browser_state),	51 SigninClientFactory::GetForBrowserState(chrome_browser_state),

52 GaiaCookieManagerServiceFactory::GetForBrowserState(	52 GaiaCookieManagerServiceFactory::GetForBrowserState(

53 chrome_browser_state)));	53 chrome_browser_state)));

54 reconcilor->Initialize(true /* start_reconcile_if_tokens_available */);	54 reconcilor->Initialize(true /* start_reconcile_if_tokens_available */);

	55 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.

55 return std::move(reconcilor);	56 return std::move(reconcilor);

56 }	57 }

57	58

58 } // namespace ios	59 } // namespace ios

OLD	NEW