Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: ios/chrome/browser/infobars/infobar_utils.mm

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/history/history_service_factory.cc ('k') | ios/chrome/browser/ios_chrome_io_thread.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/infobars/infobar_utils.mm
diff --git a/ios/chrome/browser/infobars/infobar_utils.mm b/ios/chrome/browser/infobars/infobar_utils.mm
index 46fc48e7e64a4cf868bc461bf12172a11df15d54..0ea92f10a3ecd5be02fb4b1c0743ad59559182d3 100644
--- a/ios/chrome/browser/infobars/infobar_utils.mm
+++ b/ios/chrome/browser/infobars/infobar_utils.mm
@@ -21,5 +21,6 @@ std::unique_ptr<infobars::InfoBar> CreateConfirmInfoBar(
ConfirmInfoBarController* controller =
[[ConfirmInfoBarController alloc] initWithDelegate:infobar.get()];
infobar->SetController(controller);
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
return std::move(infobar);
}
« no previous file with comments | « ios/chrome/browser/history/history_service_factory.cc ('k') | ios/chrome/browser/ios_chrome_io_thread.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698