Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: ios/chrome/browser/signin/about_signin_internals_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/signin/about_signin_internals_factory.h" 5 #include "ios/chrome/browser/signin/about_signin_internals_factory.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "components/keyed_service/ios/browser_state_dependency_manager.h" 10 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 ios::ChromeBrowserState::FromBrowserState(context); 52 ios::ChromeBrowserState::FromBrowserState(context);
53 std::unique_ptr<AboutSigninInternals> service(new AboutSigninInternals( 53 std::unique_ptr<AboutSigninInternals> service(new AboutSigninInternals(
54 OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state), 54 OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state),
55 AccountTrackerServiceFactory::GetForBrowserState(chrome_browser_state), 55 AccountTrackerServiceFactory::GetForBrowserState(chrome_browser_state),
56 SigninManagerFactory::GetForBrowserState(chrome_browser_state), 56 SigninManagerFactory::GetForBrowserState(chrome_browser_state),
57 SigninErrorControllerFactory::GetForBrowserState(chrome_browser_state), 57 SigninErrorControllerFactory::GetForBrowserState(chrome_browser_state),
58 GaiaCookieManagerServiceFactory::GetForBrowserState( 58 GaiaCookieManagerServiceFactory::GetForBrowserState(
59 chrome_browser_state))); 59 chrome_browser_state)));
60 service->Initialize( 60 service->Initialize(
61 SigninClientFactory::GetForBrowserState(chrome_browser_state)); 61 SigninClientFactory::GetForBrowserState(chrome_browser_state));
62 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
62 return std::move(service); 63 return std::move(service);
63 } 64 }
64 65
65 void AboutSigninInternalsFactory::RegisterBrowserStatePrefs( 66 void AboutSigninInternalsFactory::RegisterBrowserStatePrefs(
66 user_prefs::PrefRegistrySyncable* user_prefs) { 67 user_prefs::PrefRegistrySyncable* user_prefs) {
67 AboutSigninInternals::RegisterPrefs(user_prefs); 68 AboutSigninInternals::RegisterPrefs(user_prefs);
68 } 69 }
69 70
70 } // namespace ios 71 } // namespace ios
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698