Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: ios/chrome/browser/signin/signin_client_impl.mm

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/signin/signin_client_impl.h" 5 #include "ios/chrome/browser/signin/signin_client_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 std::unique_ptr<SigninClient::CookieChangedSubscription> 137 std::unique_ptr<SigninClient::CookieChangedSubscription>
138 SigninClientImpl::AddCookieChangedCallback( 138 SigninClientImpl::AddCookieChangedCallback(
139 const GURL& url, 139 const GURL& url,
140 const std::string& name, 140 const std::string& name,
141 const net::CookieStore::CookieChangedCallback& callback) { 141 const net::CookieStore::CookieChangedCallback& callback) {
142 scoped_refptr<net::URLRequestContextGetter> context_getter = 142 scoped_refptr<net::URLRequestContextGetter> context_getter =
143 browser_state_->GetRequestContext(); 143 browser_state_->GetRequestContext();
144 DCHECK(context_getter.get()); 144 DCHECK(context_getter.get());
145 std::unique_ptr<SigninCookieChangedSubscription> subscription( 145 std::unique_ptr<SigninCookieChangedSubscription> subscription(
146 new SigninCookieChangedSubscription(context_getter, url, name, callback)); 146 new SigninCookieChangedSubscription(context_getter, url, name, callback));
147 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
147 return std::move(subscription); 148 return std::move(subscription);
148 } 149 }
149 150
150 void SigninClientImpl::OnSignedIn(const std::string& account_id, 151 void SigninClientImpl::OnSignedIn(const std::string& account_id,
151 const std::string& gaia_id, 152 const std::string& gaia_id,
152 const std::string& username, 153 const std::string& username,
153 const std::string& password) { 154 const std::string& password) {
154 ios::ChromeBrowserStateManager* browser_state_manager = 155 ios::ChromeBrowserStateManager* browser_state_manager =
155 GetApplicationContext()->GetChromeBrowserStateManager(); 156 GetApplicationContext()->GetChromeBrowserStateManager();
156 BrowserStateInfoCache* cache = 157 BrowserStateInfoCache* cache =
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 } 233 }
233 } 234 }
234 235
235 std::unique_ptr<GaiaAuthFetcher> SigninClientImpl::CreateGaiaAuthFetcher( 236 std::unique_ptr<GaiaAuthFetcher> SigninClientImpl::CreateGaiaAuthFetcher(
236 GaiaAuthConsumer* consumer, 237 GaiaAuthConsumer* consumer,
237 const std::string& source, 238 const std::string& source,
238 net::URLRequestContextGetter* getter) { 239 net::URLRequestContextGetter* getter) {
239 return base::MakeUnique<GaiaAuthFetcherIOS>(consumer, source, getter, 240 return base::MakeUnique<GaiaAuthFetcherIOS>(consumer, source, getter,
240 browser_state_); 241 browser_state_);
241 } 242 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/signin/fake_signin_manager_builder.cc ('k') | ios/chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698