Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: ios/chrome/browser/share_extension/share_extension_service_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/share_extension/share_extension_service_factory.h" 5 #include "ios/chrome/browser/share_extension/share_extension_service_factory.h"
6 6
7 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
8 #include "components/keyed_service/ios/browser_state_dependency_manager.h" 8 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
9 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h" 9 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
10 #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h" 10 #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 std::unique_ptr<KeyedService> 44 std::unique_ptr<KeyedService>
45 ShareExtensionServiceFactory::BuildServiceInstanceFor( 45 ShareExtensionServiceFactory::BuildServiceInstanceFor(
46 web::BrowserState* context) const { 46 web::BrowserState* context) const {
47 ios::ChromeBrowserState* chrome_browser_state = 47 ios::ChromeBrowserState* chrome_browser_state =
48 ios::ChromeBrowserState::FromBrowserState(context); 48 ios::ChromeBrowserState::FromBrowserState(context);
49 std::unique_ptr<ShareExtensionService> share_extension_service( 49 std::unique_ptr<ShareExtensionService> share_extension_service(
50 new ShareExtensionService( 50 new ShareExtensionService(
51 ios::BookmarkModelFactory::GetForBrowserState(chrome_browser_state), 51 ios::BookmarkModelFactory::GetForBrowserState(chrome_browser_state),
52 ReadingListModelFactory::GetForBrowserState(chrome_browser_state))); 52 ReadingListModelFactory::GetForBrowserState(chrome_browser_state)));
53 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
53 return std::move(share_extension_service); 54 return std::move(share_extension_service);
54 } 55 }
55 56
56 web::BrowserState* ShareExtensionServiceFactory::GetBrowserStateToUse( 57 web::BrowserState* ShareExtensionServiceFactory::GetBrowserStateToUse(
57 web::BrowserState* context) const { 58 web::BrowserState* context) const {
58 return GetBrowserStateRedirectedInIncognito(context); 59 return GetBrowserStateRedirectedInIncognito(context);
59 } 60 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698