Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: ios/chrome/browser/browser_state/test_chrome_browser_state.mm

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/browser_state/test_chrome_browser_state.mm
diff --git a/ios/chrome/browser/browser_state/test_chrome_browser_state.mm b/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
index 4c4e4d86973fd09df648e4b1411f0cd912705a0c..be29b43451a8bc8556daa369fc4f822dd30ce44c 100644
--- a/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
+++ b/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
@@ -72,6 +72,7 @@ std::unique_ptr<KeyedService> BuildBookmarkModel(web::BrowserState* context) {
browser_state->GetPrefs(),
browser_state->GetStatePath(), browser_state->GetIOTaskRunner(),
web::WebThread::GetTaskRunnerForThread(web::WebThread::UI));
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
return std::move(bookmark_model);
}
« no previous file with comments | « ios/chrome/browser/bookmarks/bookmark_model_factory.cc ('k') | ios/chrome/browser/history/history_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698