ios/chrome/browser/share_extension/share_extension_service_factory.cc - Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/share_extension/share_extension_service_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_download_service_factory.cc ('k') | ios/chrome/browser/signin/about_signin_internals_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/share_extension/share_extension_service_factory.cc

diff --git a/ios/chrome/browser/share_extension/share_extension_service_factory.cc b/ios/chrome/browser/share_extension/share_extension_service_factory.cc

index 1bde0943fe35ce687c19dd30d56e624297f5c50c..52fd43252e2a54d8bbb65dcc88e29eff2e4a3519 100644

--- a/ios/chrome/browser/share_extension/share_extension_service_factory.cc

+++ b/ios/chrome/browser/share_extension/share_extension_service_factory.cc

@@ -50,6 +50,7 @@ ShareExtensionServiceFactory::BuildServiceInstanceFor(

new ShareExtensionService(

ios::BookmarkModelFactory::GetForBrowserState(chrome_browser_state),

ReadingListModelFactory::GetForBrowserState(chrome_browser_state)));

+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.

return std::move(share_extension_service);

}