Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: ios/web/web_state/web_state_impl.mm

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/test/web_view_interaction_test_util.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_state_impl.mm
diff --git a/ios/web/web_state/web_state_impl.mm b/ios/web/web_state/web_state_impl.mm
index 4c4f20edb3db92bb2014d816968bcac19444db09..6f41e9b647410ec0ce6e048f81544c82e3c96f87 100644
--- a/ios/web/web_state/web_state_impl.mm
+++ b/ios/web/web_state/web_state_impl.mm
@@ -48,9 +48,7 @@ std::unique_ptr<WebState> WebState::Create(const CreateParams& params) {
// Initialize the new session.
web_state->GetNavigationManagerImpl().InitializeSession();
- // This std::move is required to compile with the version of clang shipping
- // with Xcode 8.0+. Evalute whether the issue is fixed once a new version of
- // Xcode is released.
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
return std::move(web_state);
}
@@ -60,9 +58,7 @@ std::unique_ptr<WebState> WebState::Create(const CreateParams& params,
std::unique_ptr<WebStateImpl> web_state(
new WebStateImpl(params, session_storage));
- // This std::move is required to compile with the version of clang shipping
- // with Xcode 8.0+. Evalute whether the issue is fixed once a new version of
- // Xcode is released.
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
return std::move(web_state);
}
« no previous file with comments | « ios/web/public/test/web_view_interaction_test_util.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698