ios/chrome/browser/signin/fake_signin_manager_builder.cc - Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/signin/fake_signin_manager_builder.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/signin/fake_signin_manager_builder.cc

diff --git a/ios/chrome/browser/signin/fake_signin_manager_builder.cc b/ios/chrome/browser/signin/fake_signin_manager_builder.cc

index 8ac5c86e28ad656c9422c31926a549c3a25525be..ff0e14f9f67aecbdd5f02f8510f31ea7255c821d 100644

--- a/ios/chrome/browser/signin/fake_signin_manager_builder.cc

+++ b/ios/chrome/browser/signin/fake_signin_manager_builder.cc

@@ -30,6 +30,7 @@ std::unique_ptr<KeyedService> BuildFakeSigninManager(

manager->Initialize(nullptr);

ios::SigninManagerFactory::GetInstance()

->NotifyObserversOfSigninManagerCreationForTesting(manager.get());

+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.

return std::move(manager);

}