ios/chrome/browser/signin/account_fetcher_service_factory.cc - Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/signin/account_fetcher_service_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ios/chrome/browser/signin/account_fetcher_service_factory.h"	5 #include "ios/chrome/browser/signin/account_fetcher_service_factory.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "base/memory/singleton.h"	9 #include "base/memory/singleton.h"

10 #include "components/keyed_service/ios/browser_state_dependency_manager.h"	10 #include "components/keyed_service/ios/browser_state_dependency_manager.h"

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 std::unique_ptr<KeyedService>	48 std::unique_ptr<KeyedService>

49 AccountFetcherServiceFactory::BuildServiceInstanceFor(	49 AccountFetcherServiceFactory::BuildServiceInstanceFor(

50 web::BrowserState* context) const {	50 web::BrowserState* context) const {

51 ios::ChromeBrowserState* browser_state =	51 ios::ChromeBrowserState* browser_state =

52 ios::ChromeBrowserState::FromBrowserState(context);	52 ios::ChromeBrowserState::FromBrowserState(context);

53 std::unique_ptr<AccountFetcherService> service(new AccountFetcherService());	53 std::unique_ptr<AccountFetcherService> service(new AccountFetcherService());

54 service->Initialize(	54 service->Initialize(

55 SigninClientFactory::GetForBrowserState(browser_state),	55 SigninClientFactory::GetForBrowserState(browser_state),

56 OAuth2TokenServiceFactory::GetForBrowserState(browser_state),	56 OAuth2TokenServiceFactory::GetForBrowserState(browser_state),

57 ios::AccountTrackerServiceFactory::GetForBrowserState(browser_state));	57 ios::AccountTrackerServiceFactory::GetForBrowserState(browser_state));

	58 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.

58 return std::move(service);	59 return std::move(service);

59 }	60 }

60	61

61 } // namespace ios	62 } // namespace ios

OLD	NEW