Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/signin/account_reconcilor_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/signin/account_reconcilor_factory.cc
diff --git a/ios/chrome/browser/signin/account_reconcilor_factory.cc b/ios/chrome/browser/signin/account_reconcilor_factory.cc
index a4b81e3438fbbfac731db97aea94e07a9b202590..8b84a8c9fb277f458d313046da739c5b94816819 100644
--- a/ios/chrome/browser/signin/account_reconcilor_factory.cc
+++ b/ios/chrome/browser/signin/account_reconcilor_factory.cc
@@ -52,6 +52,7 @@ std::unique_ptr<KeyedService> AccountReconcilorFactory::BuildServiceInstanceFor(
GaiaCookieManagerServiceFactory::GetForBrowserState(
chrome_browser_state)));
reconcilor->Initialize(true /* start_reconcile_if_tokens_available */);
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
return std::move(reconcilor);
}

Powered by Google App Engine
This is Rietveld 408576698