Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h" 5 #include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 init_params.network_time_update_callback = base::Bind(&UpdateNetworkTime); 140 init_params.network_time_update_callback = base::Bind(&UpdateNetworkTime);
141 init_params.base_directory = browser_state->GetStatePath(); 141 init_params.base_directory = browser_state->GetStatePath();
142 init_params.url_request_context = browser_state->GetRequestContext(); 142 init_params.url_request_context = browser_state->GetRequestContext();
143 init_params.debug_identifier = browser_state->GetDebugName(); 143 init_params.debug_identifier = browser_state->GetDebugName();
144 init_params.channel = ::GetChannel(); 144 init_params.channel = ::GetChannel();
145 145
146 auto pss = base::MakeUnique<ProfileSyncService>(std::move(init_params)); 146 auto pss = base::MakeUnique<ProfileSyncService>(std::move(init_params));
147 147
148 // Will also initialize the sync client. 148 // Will also initialize the sync client.
149 pss->Initialize(); 149 pss->Initialize();
150 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
150 return std::move(pss); 151 return std::move(pss);
151 } 152 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/signin/signin_manager_factory.cc ('k') | ios/chrome/browser/translate/chrome_ios_translate_client.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698