Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/autofill/personal_data_manager_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc
diff --git a/ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc b/ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc
index ed876b253b337bd6661e029c4a73b3e78ff71aaf..9f46f3e9c2762ae701d886fce73cfcc778425326 100644
--- a/ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc
+++ b/ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc
@@ -39,6 +39,7 @@ std::unique_ptr<KeyedService> BuildInMemoryURLIndex(
web::WebThread::GetBlockingPool(), browser_state->GetStatePath(),
schemes_to_whilelist));
in_memory_url_index->Init();
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
return std::move(in_memory_url_index);
}
« no previous file with comments | « no previous file | ios/chrome/browser/autofill/personal_data_manager_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698