ios/chrome/browser/signin/fake_signin_manager_builder.cc - Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/signin/fake_signin_manager_builder.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/signin/authentication_service_factory.mm ('k') | ios/chrome/browser/signin/signin_client_impl.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ios/chrome/browser/signin/fake_signin_manager_builder.h"	5 #include "ios/chrome/browser/signin/fake_signin_manager_builder.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "components/signin/core/browser/fake_signin_manager.h"	9 #include "components/signin/core/browser/fake_signin_manager.h"

10 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"	10 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"

(...skipping 12 matching lines...) Expand all Loading...
23 std::unique_ptr<SigninManager> manager(new FakeSigninManager(	23 std::unique_ptr<SigninManager> manager(new FakeSigninManager(

24 SigninClientFactory::GetForBrowserState(chrome_browser_state),	24 SigninClientFactory::GetForBrowserState(chrome_browser_state),

25 OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state),	25 OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state),

26 ios::AccountTrackerServiceFactory::GetForBrowserState(	26 ios::AccountTrackerServiceFactory::GetForBrowserState(

27 chrome_browser_state),	27 chrome_browser_state),

28 ios::GaiaCookieManagerServiceFactory::GetForBrowserState(	28 ios::GaiaCookieManagerServiceFactory::GetForBrowserState(

29 chrome_browser_state)));	29 chrome_browser_state)));

30 manager->Initialize(nullptr);	30 manager->Initialize(nullptr);

31 ios::SigninManagerFactory::GetInstance()	31 ios::SigninManagerFactory::GetInstance()

32 ->NotifyObserversOfSigninManagerCreationForTesting(manager.get());	32 ->NotifyObserversOfSigninManagerCreationForTesting(manager.get());

	33 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.

33 return std::move(manager);	34 return std::move(manager);

34 }	35 }

35	36

36 } // namespace ios	37 } // namespace ios

OLD	NEW