Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: ios/web/public/test/web_view_interaction_test_util.mm

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/translate/chrome_ios_translate_client.mm ('k') | ios/web/web_state/web_state_impl.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/test/web_view_interaction_test_util.mm
diff --git a/ios/web/public/test/web_view_interaction_test_util.mm b/ios/web/public/test/web_view_interaction_test_util.mm
index f29ee56d0102500a165cd8c4a1a6b08d7ba2b762..da4e786561c629b4084dad239cb5510a9b337e37 100644
--- a/ios/web/public/test/web_view_interaction_test_util.mm
+++ b/ios/web/public/test/web_view_interaction_test_util.mm
@@ -52,6 +52,7 @@ std::unique_ptr<base::Value> ExecuteJavaScript(web::WebState* web_state,
// Fixes the following compilation failure:
// ../web_view_matchers.mm:ll:cc: error: call to implicitly-deleted copy
// constructor of 'std::unique_ptr<base::Value>'
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
std::unique_ptr<base::Value> stack_result = std::move(result);
return stack_result;
}
« no previous file with comments | « ios/chrome/browser/translate/chrome_ios_translate_client.mm ('k') | ios/web/web_state/web_state_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698