ios/chrome/browser/autofill/personal_data_manager_factory.cc - Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/autofill/personal_data_manager_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ios/chrome/browser/autofill/personal_data_manager_factory.h"	5 #include "ios/chrome/browser/autofill/personal_data_manager_factory.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "base/memory/singleton.h"	9 #include "base/memory/singleton.h"

10 #include "components/autofill/core/browser/personal_data_manager.h"	10 #include "components/autofill/core/browser/personal_data_manager.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 std::unique_ptr<PersonalDataManager> service(	52 std::unique_ptr<PersonalDataManager> service(

53 new PersonalDataManager(GetApplicationContext()->GetApplicationLocale()));	53 new PersonalDataManager(GetApplicationContext()->GetApplicationLocale()));

54 service->Init(	54 service->Init(

55 ios::WebDataServiceFactory::GetAutofillWebDataForBrowserState(	55 ios::WebDataServiceFactory::GetAutofillWebDataForBrowserState(

56 chrome_browser_state, ServiceAccessType::EXPLICIT_ACCESS),	56 chrome_browser_state, ServiceAccessType::EXPLICIT_ACCESS),

57 chrome_browser_state->GetPrefs(),	57 chrome_browser_state->GetPrefs(),

58 ios::AccountTrackerServiceFactory::GetForBrowserState(	58 ios::AccountTrackerServiceFactory::GetForBrowserState(

59 chrome_browser_state),	59 chrome_browser_state),

60 ios::SigninManagerFactory::GetForBrowserState(chrome_browser_state),	60 ios::SigninManagerFactory::GetForBrowserState(chrome_browser_state),

61 chrome_browser_state->IsOffTheRecord());	61 chrome_browser_state->IsOffTheRecord());

	62 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.

62 return std::move(service);	63 return std::move(service);

63 }	64 }

64	65

65 } // namespace autofill	66 } // namespace autofill

OLD	NEW