Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/signin/signin_manager_factory.cc

Issue 2762973002: [ios] Add TODO to record usages of "return std::move(foo)" pattern. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/signin/signin_manager_factory.cc
diff --git a/ios/chrome/browser/signin/signin_manager_factory.cc b/ios/chrome/browser/signin/signin_manager_factory.cc
index 201daba977b654557a9615f4d7f5be70565ebdcc..aa637b9f25b0877e9876bbe97635833028f598d6 100644
--- a/ios/chrome/browser/signin/signin_manager_factory.cc
+++ b/ios/chrome/browser/signin/signin_manager_factory.cc
@@ -93,6 +93,7 @@ std::unique_ptr<KeyedService> SigninManagerFactory::BuildServiceInstanceFor(
service->Initialize(GetApplicationContext()->GetLocalState());
for (auto& observer : observer_list_)
observer.SigninManagerCreated(service.get());
+ // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
return std::move(service);
}
« no previous file with comments | « ios/chrome/browser/signin/signin_client_impl.mm ('k') | ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698