Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
jam, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, extensions-reviews_chromium.org, Peter Beverloo, mac-reviews_chromium.org, jam, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, einbinder+watch-test-runner_chromium.org, android-webview-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename JavaScript "messages" to "dialogs". BUG=690081 TEST=no user-visible changes CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2684093002 Cr-Commit-Position: refs/heads/master@{#449367} Committed: https://chromium.googlesource.com/chromium/src/+/777ff4555115c5fa24f6a3125c6a4812b36aca36

Patch Set 1 #

Patch Set 2 : win fox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -250 lines) Patch
M android_webview/browser/aw_contents_client_bridge_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_javascript_dialog_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_javascript_dialog_manager.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_mac.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/app_modal/javascript_app_modal_dialog.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/app_modal/javascript_app_modal_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/app_modal/javascript_dialog_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/app_modal/javascript_dialog_manager.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M components/app_modal/views/javascript_app_modal_dialog_views.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/common/frame_messages.h View 3 chunks +11 lines, -11 lines 0 comments Download
M content/public/browser/javascript_dialog_manager.h View 2 chunks +8 lines, -9 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A content/public/common/javascript_dialog_type.h View 1 chunk +18 lines, -0 lines 0 comments Download
D content/public/common/javascript_message_type.h View 1 chunk +0 lines, -18 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_javascript_dialog.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_win.cc View 1 3 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/guest_view/web_view/javascript_dialog_helper.h View 1 chunk +7 lines, -8 lines 0 comments Download
M extensions/browser/guest_view/web_view/javascript_dialog_helper.cc View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Avi (use Gerrit)
John for overall review, Nasko for security review. Just a rename for clarification.
3 years, 10 months ago (2017-02-09 03:01:22 UTC) #11
jam
lgtm
3 years, 10 months ago (2017-02-09 17:19:27 UTC) #12
nasko
IPC LGTM
3 years, 10 months ago (2017-02-09 17:49:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684093002/20001
3 years, 10 months ago (2017-02-09 18:58:24 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 19:05:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/777ff4555115c5fa24f6a3125c6a...

Powered by Google App Engine
This is Rietveld 408576698