Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
index 7ecaef55656d4711bb50d4934e9ead4589b602c2..aef704ced433f470a897b33dc9c1916738abcb4f 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
@@ -28,7 +28,7 @@ class JavaScriptDialogViews : public JavaScriptDialog,
content::WebContents* parent_web_contents,
content::WebContents* alerting_web_contents,
const base::string16& title,
- content::JavaScriptMessageType message_type,
+ content::JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const content::JavaScriptDialogManager::DialogClosedCallback&
@@ -58,14 +58,14 @@ class JavaScriptDialogViews : public JavaScriptDialog,
content::WebContents* parent_web_contents,
content::WebContents* alerting_web_contents,
const base::string16& title,
- content::JavaScriptMessageType message_type,
+ content::JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const content::JavaScriptDialogManager::DialogClosedCallback&
dialog_callback);
base::string16 title_;
- content::JavaScriptMessageType message_type_;
+ content::JavaScriptDialogType dialog_type_;
base::string16 message_text_;
base::string16 default_prompt_text_;
content::JavaScriptDialogManager::DialogClosedCallback dialog_callback_;

Powered by Google App Engine
This is Rietveld 408576698