Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: components/app_modal/views/javascript_app_modal_dialog_views.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/views/javascript_app_modal_dialog_views.cc
diff --git a/components/app_modal/views/javascript_app_modal_dialog_views.cc b/components/app_modal/views/javascript_app_modal_dialog_views.cc
index a56abe26cfb15bd1070679225880d9ab607cb6a9..eec5d89020b149339ed9ff8e3a57af1cf4d83ef2 100644
--- a/components/app_modal/views/javascript_app_modal_dialog_views.cc
+++ b/components/app_modal/views/javascript_app_modal_dialog_views.cc
@@ -24,8 +24,8 @@ JavaScriptAppModalDialogViews::JavaScriptAppModalDialogViews(
JavaScriptAppModalDialog* parent)
: parent_(parent) {
int options = views::MessageBoxView::DETECT_DIRECTIONALITY;
- if (parent->javascript_message_type() ==
- content::JAVASCRIPT_MESSAGE_TYPE_PROMPT)
+ if (parent->javascript_dialog_type() ==
+ content::JAVASCRIPT_DIALOG_TYPE_PROMPT)
options |= views::MessageBoxView::HAS_PROMPT_FIELD;
views::MessageBoxView::InitParams params(parent->message_text());
@@ -85,8 +85,8 @@ int JavaScriptAppModalDialogViews::GetDefaultDialogButton() const {
}
int JavaScriptAppModalDialogViews::GetDialogButtons() const {
- if (parent_->javascript_message_type() ==
- content::JAVASCRIPT_MESSAGE_TYPE_ALERT)
+ if (parent_->javascript_dialog_type() ==
+ content::JAVASCRIPT_DIALOG_TYPE_ALERT)
return ui::DIALOG_BUTTON_OK;
return ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL;
« no previous file with comments | « components/app_modal/javascript_dialog_manager.cc ('k') | content/browser/devtools/protocol/devtools_protocol_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698