Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: content/shell/browser/shell_javascript_dialog.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_javascript_dialog.h
diff --git a/content/shell/browser/shell_javascript_dialog.h b/content/shell/browser/shell_javascript_dialog.h
index b113385640bbbd4aaa962e98421234ef1af603f7..c4461a60ac67f3ebb833d8888753599d5d8962c8 100644
--- a/content/shell/browser/shell_javascript_dialog.h
+++ b/content/shell/browser/shell_javascript_dialog.h
@@ -26,7 +26,7 @@ class ShellJavaScriptDialog {
ShellJavaScriptDialog(
ShellJavaScriptDialogManager* manager,
gfx::NativeWindow parent_window,
- JavaScriptMessageType message_type,
+ JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const JavaScriptDialogManager::DialogClosedCallback& callback);
@@ -42,7 +42,7 @@ class ShellJavaScriptDialog {
ShellJavaScriptDialogHelper* helper_; // owned
#elif defined(OS_WIN)
ShellJavaScriptDialogManager* manager_;
- JavaScriptMessageType message_type_;
+ JavaScriptDialogType dialog_type_;
HWND dialog_win_;
base::string16 message_text_;
base::string16 default_prompt_text_;

Powered by Google App Engine
This is Rietveld 408576698