content/shell/browser/shell_javascript_dialog_manager.h - Issue 2684093002: Rename JavaScript "messages" to "dialogs".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_javascript_dialog_manager.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)

Patch Set: win fox Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/shell_javascript_dialog_manager.h

diff --git a/content/shell/browser/shell_javascript_dialog_manager.h b/content/shell/browser/shell_javascript_dialog_manager.h

index 54482bf4431f466f2ac081ebc62cb885be7ed408..ba627bae6f0e7c2455e7d3c6e4ba43eb979d8984 100644

--- a/content/shell/browser/shell_javascript_dialog_manager.h

+++ b/content/shell/browser/shell_javascript_dialog_manager.h

@@ -25,7 +25,7 @@ class ShellJavaScriptDialogManager : public JavaScriptDialogManager {

// JavaScriptDialogManager:

void RunJavaScriptDialog(WebContents* web_contents,

const GURL& origin_url,

- JavaScriptMessageType javascript_message_type,

+ JavaScriptDialogType dialog_type,

const base::string16& message_text,

const base::string16& default_prompt_text,

const DialogClosedCallback& callback,