Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
index 35cc6d831999c0fc309b88a0cd5f7d5688a3f236..1417cd780aa9759bd9798ef3321d93b47a173153 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
@@ -41,7 +41,7 @@ class JavaScriptDialogTabHelper
// JavaScriptDialogManager:
void RunJavaScriptDialog(content::WebContents* web_contents,
const GURL& origin_url,
- content::JavaScriptMessageType message_type,
+ content::JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const DialogClosedCallback& callback,
@@ -88,8 +88,8 @@ class JavaScriptDialogTabHelper
base::WeakPtr<JavaScriptDialog> dialog_;
// The type of dialog being displayed. Only valid when |dialog_| is non-null.
- content::JavaScriptMessageType message_type_ =
- content::JavaScriptMessageType::JAVASCRIPT_MESSAGE_TYPE_ALERT;
+ content::JavaScriptDialogType dialog_type_ =
+ content::JavaScriptDialogType::JAVASCRIPT_DIALOG_TYPE_ALERT;
// The callback provided for when the dialog is closed. Usually the dialog
// itself calls it, but in the cases where the dialog is closed not by the

Powered by Google App Engine
This is Rietveld 408576698