Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/javascript_app_modal_dialog_android.h" 5 #include "chrome/browser/ui/android/javascript_app_modal_dialog_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/metrics/histogram_macros.h" 11 #include "base/metrics/histogram_macros.h"
12 #include "chrome/browser/android/tab_android.h" 12 #include "chrome/browser/android/tab_android.h"
13 #include "chrome/browser/ui/javascript_dialogs/chrome_javascript_native_dialog_f actory.h" 13 #include "chrome/browser/ui/javascript_dialogs/chrome_javascript_native_dialog_f actory.h"
14 #include "components/app_modal/app_modal_dialog_queue.h" 14 #include "components/app_modal/app_modal_dialog_queue.h"
15 #include "components/app_modal/javascript_app_modal_dialog.h" 15 #include "components/app_modal/javascript_app_modal_dialog.h"
16 #include "components/app_modal/javascript_dialog_manager.h" 16 #include "components/app_modal/javascript_dialog_manager.h"
17 #include "components/app_modal/javascript_native_dialog_factory.h" 17 #include "components/app_modal/javascript_native_dialog_factory.h"
18 #include "content/public/browser/browser_thread.h" 18 #include "content/public/browser/browser_thread.h"
19 #include "content/public/browser/web_contents.h" 19 #include "content/public/browser/web_contents.h"
20 #include "content/public/browser/web_contents_delegate.h" 20 #include "content/public/browser/web_contents_delegate.h"
21 #include "content/public/common/javascript_message_type.h" 21 #include "content/public/common/javascript_dialog_type.h"
22 #include "jni/JavascriptAppModalDialog_jni.h" 22 #include "jni/JavascriptAppModalDialog_jni.h"
23 #include "ui/android/window_android.h" 23 #include "ui/android/window_android.h"
24 24
25 using base::android::AttachCurrentThread; 25 using base::android::AttachCurrentThread;
26 using base::android::ConvertUTF16ToJavaString; 26 using base::android::ConvertUTF16ToJavaString;
27 using base::android::JavaParamRef; 27 using base::android::JavaParamRef;
28 using base::android::ScopedJavaGlobalRef; 28 using base::android::ScopedJavaGlobalRef;
29 using base::android::ScopedJavaLocalRef; 29 using base::android::ScopedJavaLocalRef;
30 30
31 JavascriptAppModalDialogAndroid::JavascriptAppModalDialogAndroid( 31 JavascriptAppModalDialogAndroid::JavascriptAppModalDialogAndroid(
(...skipping 23 matching lines...) Expand all
55 return; 55 return;
56 } 56 }
57 57
58 ScopedJavaLocalRef<jobject> dialog_object; 58 ScopedJavaLocalRef<jobject> dialog_object;
59 ScopedJavaLocalRef<jstring> title = 59 ScopedJavaLocalRef<jstring> title =
60 ConvertUTF16ToJavaString(env, dialog_->title()); 60 ConvertUTF16ToJavaString(env, dialog_->title());
61 ScopedJavaLocalRef<jstring> message = 61 ScopedJavaLocalRef<jstring> message =
62 ConvertUTF16ToJavaString(env, dialog_->message_text()); 62 ConvertUTF16ToJavaString(env, dialog_->message_text());
63 63
64 bool foremost = tab->IsUserInteractable(); 64 bool foremost = tab->IsUserInteractable();
65 switch (dialog_->javascript_message_type()) { 65 switch (dialog_->javascript_dialog_type()) {
66 case content::JAVASCRIPT_MESSAGE_TYPE_ALERT: { 66 case content::JAVASCRIPT_DIALOG_TYPE_ALERT: {
67 UMA_HISTOGRAM_BOOLEAN("JSDialogs.IsForemost.Alert", foremost); 67 UMA_HISTOGRAM_BOOLEAN("JSDialogs.IsForemost.Alert", foremost);
68 dialog_object = Java_JavascriptAppModalDialog_createAlertDialog( 68 dialog_object = Java_JavascriptAppModalDialog_createAlertDialog(
69 env, title, message, dialog_->display_suppress_checkbox()); 69 env, title, message, dialog_->display_suppress_checkbox());
70 break; 70 break;
71 } 71 }
72 case content::JAVASCRIPT_MESSAGE_TYPE_CONFIRM: { 72 case content::JAVASCRIPT_DIALOG_TYPE_CONFIRM: {
73 if (dialog_->is_before_unload_dialog()) { 73 if (dialog_->is_before_unload_dialog()) {
74 dialog_object = Java_JavascriptAppModalDialog_createBeforeUnloadDialog( 74 dialog_object = Java_JavascriptAppModalDialog_createBeforeUnloadDialog(
75 env, title, message, dialog_->is_reload(), 75 env, title, message, dialog_->is_reload(),
76 dialog_->display_suppress_checkbox()); 76 dialog_->display_suppress_checkbox());
77 } else { 77 } else {
78 UMA_HISTOGRAM_BOOLEAN("JSDialogs.IsForemost.Confirm", foremost); 78 UMA_HISTOGRAM_BOOLEAN("JSDialogs.IsForemost.Confirm", foremost);
79 dialog_object = Java_JavascriptAppModalDialog_createConfirmDialog( 79 dialog_object = Java_JavascriptAppModalDialog_createConfirmDialog(
80 env, title, message, dialog_->display_suppress_checkbox()); 80 env, title, message, dialog_->display_suppress_checkbox());
81 } 81 }
82 break; 82 break;
83 } 83 }
84 case content::JAVASCRIPT_MESSAGE_TYPE_PROMPT: { 84 case content::JAVASCRIPT_DIALOG_TYPE_PROMPT: {
85 UMA_HISTOGRAM_BOOLEAN("JSDialogs.IsForemost.Prompt", foremost); 85 UMA_HISTOGRAM_BOOLEAN("JSDialogs.IsForemost.Prompt", foremost);
86 ScopedJavaLocalRef<jstring> default_prompt_text = 86 ScopedJavaLocalRef<jstring> default_prompt_text =
87 ConvertUTF16ToJavaString(env, dialog_->default_prompt_text()); 87 ConvertUTF16ToJavaString(env, dialog_->default_prompt_text());
88 dialog_object = Java_JavascriptAppModalDialog_createPromptDialog( 88 dialog_object = Java_JavascriptAppModalDialog_createPromptDialog(
89 env, title, message, dialog_->display_suppress_checkbox(), 89 env, title, message, dialog_->display_suppress_checkbox(),
90 default_prompt_text); 90 default_prompt_text);
91 break; 91 break;
92 } 92 }
93 default: 93 default:
94 NOTREACHED(); 94 NOTREACHED();
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogAndroidFactory); 199 DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogAndroidFactory);
200 }; 200 };
201 201
202 } // namespace 202 } // namespace
203 203
204 void InstallChromeJavaScriptNativeDialogFactory() { 204 void InstallChromeJavaScriptNativeDialogFactory() {
205 app_modal::JavaScriptDialogManager::GetInstance()->SetNativeDialogFactory( 205 app_modal::JavaScriptDialogManager::GetInstance()->SetNativeDialogFactory(
206 base::WrapUnique(new ChromeJavaScriptNativeDialogAndroidFactory)); 206 base::WrapUnique(new ChromeJavaScriptNativeDialogAndroidFactory));
207 } 207 }
208 208
OLDNEW
« no previous file with comments | « android_webview/native/aw_contents_client_bridge.cc ('k') | chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698