Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h" 5 #include "chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h"
6 6
7 #import "base/mac/scoped_nsobject.h" 7 #import "base/mac/scoped_nsobject.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h" 10 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h"
11 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sh eet.h" 11 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sh eet.h"
12 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h" 12 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
13 #import "chrome/browser/ui/cocoa/key_equivalent_constants.h" 13 #import "chrome/browser/ui/cocoa/key_equivalent_constants.h"
14 #include "ui/base/l10n/l10n_util_mac.h" 14 #include "ui/base/l10n/l10n_util_mac.h"
15 #include "ui/strings/grit/ui_strings.h" 15 #include "ui/strings/grit/ui_strings.h"
16 16
17 @class JavaScriptDialogCocoaBridge; 17 @class JavaScriptDialogCocoaBridge;
18 18
19 class JavaScriptDialogCocoa::JavaScriptDialogCocoaImpl 19 class JavaScriptDialogCocoa::JavaScriptDialogCocoaImpl
20 : public ConstrainedWindowMacDelegate { 20 : public ConstrainedWindowMacDelegate {
21 public: 21 public:
22 JavaScriptDialogCocoaImpl( 22 JavaScriptDialogCocoaImpl(
23 JavaScriptDialogCocoa* parent, 23 JavaScriptDialogCocoa* parent,
24 content::WebContents* parent_web_contents, 24 content::WebContents* parent_web_contents,
25 content::WebContents* alerting_web_contents, 25 content::WebContents* alerting_web_contents,
26 const base::string16& title, 26 const base::string16& title,
27 content::JavaScriptMessageType message_type, 27 content::JavaScriptDialogType dialog_type,
28 const base::string16& message_text, 28 const base::string16& message_text,
29 const base::string16& default_prompt_text, 29 const base::string16& default_prompt_text,
30 const content::JavaScriptDialogManager::DialogClosedCallback& 30 const content::JavaScriptDialogManager::DialogClosedCallback&
31 dialog_callback); 31 dialog_callback);
32 virtual ~JavaScriptDialogCocoaImpl() = default; 32 virtual ~JavaScriptDialogCocoaImpl() = default;
33 33
34 // Callbacks from the bridge when buttons are clicked. 34 // Callbacks from the bridge when buttons are clicked.
35 void Accept(); 35 void Accept();
36 void Cancel(); 36 void Cancel();
37 37
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 dialogImpl_->Cancel(); 75 dialogImpl_->Cancel();
76 } 76 }
77 77
78 @end 78 @end
79 79
80 JavaScriptDialogCocoa::JavaScriptDialogCocoaImpl::JavaScriptDialogCocoaImpl( 80 JavaScriptDialogCocoa::JavaScriptDialogCocoaImpl::JavaScriptDialogCocoaImpl(
81 JavaScriptDialogCocoa* parent, 81 JavaScriptDialogCocoa* parent,
82 content::WebContents* parent_web_contents, 82 content::WebContents* parent_web_contents,
83 content::WebContents* alerting_web_contents, 83 content::WebContents* alerting_web_contents,
84 const base::string16& title, 84 const base::string16& title,
85 content::JavaScriptMessageType message_type, 85 content::JavaScriptDialogType dialog_type,
86 const base::string16& message_text, 86 const base::string16& message_text,
87 const base::string16& default_prompt_text, 87 const base::string16& default_prompt_text,
88 const content::JavaScriptDialogManager::DialogClosedCallback& 88 const content::JavaScriptDialogManager::DialogClosedCallback&
89 dialog_callback) 89 dialog_callback)
90 : dialog_callback_(dialog_callback), parent_(parent) { 90 : dialog_callback_(dialog_callback), parent_(parent) {
91 bridge_.reset([[JavaScriptDialogCocoaBridge alloc] initWithDialogImpl:this]); 91 bridge_.reset([[JavaScriptDialogCocoaBridge alloc] initWithDialogImpl:this]);
92 92
93 alert_.reset([[ConstrainedWindowAlert alloc] init]); 93 alert_.reset([[ConstrainedWindowAlert alloc] init]);
94 [alert_ setMessageText:base::SysUTF16ToNSString(title)]; 94 [alert_ setMessageText:base::SysUTF16ToNSString(title)];
95 [alert_ setInformativeText:base::SysUTF16ToNSString(message_text)]; 95 [alert_ setInformativeText:base::SysUTF16ToNSString(message_text)];
96 [alert_ addButtonWithTitle:l10n_util::GetNSStringWithFixup(IDS_APP_OK) 96 [alert_ addButtonWithTitle:l10n_util::GetNSStringWithFixup(IDS_APP_OK)
97 keyEquivalent:kKeyEquivalentReturn 97 keyEquivalent:kKeyEquivalentReturn
98 target:bridge_ 98 target:bridge_
99 action:@selector(onAcceptButton:)]; 99 action:@selector(onAcceptButton:)];
100 if (message_type != content::JAVASCRIPT_MESSAGE_TYPE_ALERT) { 100 if (dialog_type != content::JAVASCRIPT_DIALOG_TYPE_ALERT) {
101 [alert_ addButtonWithTitle:l10n_util::GetNSStringWithFixup(IDS_APP_CANCEL) 101 [alert_ addButtonWithTitle:l10n_util::GetNSStringWithFixup(IDS_APP_CANCEL)
102 keyEquivalent:kKeyEquivalentEscape 102 keyEquivalent:kKeyEquivalentEscape
103 target:bridge_ 103 target:bridge_
104 action:@selector(onCancelButton:)]; 104 action:@selector(onCancelButton:)];
105 } 105 }
106 if (message_type == content::JAVASCRIPT_MESSAGE_TYPE_PROMPT) { 106 if (dialog_type == content::JAVASCRIPT_DIALOG_TYPE_PROMPT) {
107 textField_.reset( 107 textField_.reset(
108 [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 460, 22)]); 108 [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 460, 22)]);
109 [[textField_ cell] setLineBreakMode:NSLineBreakByTruncatingTail]; 109 [[textField_ cell] setLineBreakMode:NSLineBreakByTruncatingTail];
110 [textField_ setStringValue:base::SysUTF16ToNSString(default_prompt_text)]; 110 [textField_ setStringValue:base::SysUTF16ToNSString(default_prompt_text)];
111 [alert_ setAccessoryView:textField_]; 111 [alert_ setAccessoryView:textField_];
112 } 112 }
113 [[alert_ closeButton] removeFromSuperview]; 113 [[alert_ closeButton] removeFromSuperview];
114 [alert_ layout]; 114 [alert_ layout];
115 115
116 base::scoped_nsobject<CustomConstrainedWindowSheet> sheet( 116 base::scoped_nsobject<CustomConstrainedWindowSheet> sheet(
(...skipping 29 matching lines...) Expand all
146 window_->CloseWebContentsModalDialog(); 146 window_->CloseWebContentsModalDialog();
147 } 147 }
148 148
149 JavaScriptDialogCocoa::~JavaScriptDialogCocoa() = default; 149 JavaScriptDialogCocoa::~JavaScriptDialogCocoa() = default;
150 150
151 // static 151 // static
152 base::WeakPtr<JavaScriptDialogCocoa> JavaScriptDialogCocoa::Create( 152 base::WeakPtr<JavaScriptDialogCocoa> JavaScriptDialogCocoa::Create(
153 content::WebContents* parent_web_contents, 153 content::WebContents* parent_web_contents,
154 content::WebContents* alerting_web_contents, 154 content::WebContents* alerting_web_contents,
155 const base::string16& title, 155 const base::string16& title,
156 content::JavaScriptMessageType message_type, 156 content::JavaScriptDialogType dialog_type,
157 const base::string16& message_text, 157 const base::string16& message_text,
158 const base::string16& default_prompt_text, 158 const base::string16& default_prompt_text,
159 const content::JavaScriptDialogManager::DialogClosedCallback& 159 const content::JavaScriptDialogManager::DialogClosedCallback&
160 dialog_callback) { 160 dialog_callback) {
161 return (new JavaScriptDialogCocoa(parent_web_contents, alerting_web_contents, 161 return (new JavaScriptDialogCocoa(parent_web_contents, alerting_web_contents,
162 title, message_type, message_text, 162 title, dialog_type, message_text,
163 default_prompt_text, dialog_callback)) 163 default_prompt_text, dialog_callback))
164 ->weak_factory_.GetWeakPtr(); 164 ->weak_factory_.GetWeakPtr();
165 } 165 }
166 166
167 void JavaScriptDialogCocoa::CloseDialogWithoutCallback() { 167 void JavaScriptDialogCocoa::CloseDialogWithoutCallback() {
168 impl_->dialog_callback_.Reset(); 168 impl_->dialog_callback_.Reset();
169 impl_->window_->CloseWebContentsModalDialog(); 169 impl_->window_->CloseWebContentsModalDialog();
170 } 170 }
171 171
172 JavaScriptDialogCocoa::JavaScriptDialogCocoa( 172 JavaScriptDialogCocoa::JavaScriptDialogCocoa(
173 content::WebContents* parent_web_contents, 173 content::WebContents* parent_web_contents,
174 content::WebContents* alerting_web_contents, 174 content::WebContents* alerting_web_contents,
175 const base::string16& title, 175 const base::string16& title,
176 content::JavaScriptMessageType message_type, 176 content::JavaScriptDialogType dialog_type,
177 const base::string16& message_text, 177 const base::string16& message_text,
178 const base::string16& default_prompt_text, 178 const base::string16& default_prompt_text,
179 const content::JavaScriptDialogManager::DialogClosedCallback& 179 const content::JavaScriptDialogManager::DialogClosedCallback&
180 dialog_callback) 180 dialog_callback)
181 : JavaScriptDialog(parent_web_contents), 181 : JavaScriptDialog(parent_web_contents),
182 impl_(base::MakeUnique<JavaScriptDialogCocoaImpl>(this, 182 impl_(base::MakeUnique<JavaScriptDialogCocoaImpl>(this,
183 parent_web_contents, 183 parent_web_contents,
184 alerting_web_contents, 184 alerting_web_contents,
185 title, 185 title,
186 message_type, 186 dialog_type,
187 message_text, 187 message_text,
188 default_prompt_text, 188 default_prompt_text,
189 dialog_callback)), 189 dialog_callback)),
190 weak_factory_(this) {} 190 weak_factory_(this) {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698